Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fullName in formattedAssertion #4273

Merged
merged 1 commit into from
Aug 15, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions packages/jest-util/src/__tests__/format_test_results_test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/**
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
*/

'use strict';

const formatTestResults = require('../formatTestResults');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be using underscores to match packages/jest-util/src/format_test_results.js?

Copy link
Contributor Author

@aifreedom aifreedom Aug 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source file's name is formatTestResults.js while lint asks me to snake_case the test file. Not sure what's the right way to unify them..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can rename that file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what? The source file on latest master is format_test_results.js, so I'm not sure if I understand that comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I didn't notice that after I rebase. If that's the case, how come the require worked??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, because this was called _test but we only look for .test files, so this wasn't actually run. I'll fix it.


describe('formatTestResults', () => {
const assertion = {
fullName: 'TestedModule#aMethod when some condition is met returns true',
status: 'passed',
title: 'returns true',
};

const results = {
testResults: [
{
numFailingTests: 0,
perfStats: {end: 2, start: 1},
testResults: [assertion],
},
],
};

it('includes test full name', () => {
const result = formatTestResults(results, null, null);
expect(result.testResults[0].assertionResults[0].fullName).toEqual(
assertion.fullName,
);
});
});
1 change: 1 addition & 0 deletions packages/jest-util/src/format_test_results.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ function formatTestAssertion(
): FormattedAssertionResult {
const result: FormattedAssertionResult = {
failureMessages: null,
fullName: assertion.fullName,
status: assertion.status,
title: assertion.title,
};
Expand Down
3 changes: 2 additions & 1 deletion types/TestResult.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,10 @@ export type AssertionResult = {|
|};

export type FormattedAssertionResult = {
failureMessages: Array<string> | null,
fullName: string,
status: Status,
title: string,
failureMessages: Array<string> | null,
};

export type AggregatedResultWithoutCoverage = {
Expand Down