Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Promise detection code in jest-circus to support non-global Promise implementations #4375

Merged
merged 2 commits into from
Aug 27, 2017
Merged

Change Promise detection code in jest-circus to support non-global Promise implementations #4375

merged 2 commits into from
Aug 27, 2017

Commits on Aug 27, 2017

  1. Change Promise detection code in jest-circus to support non-global Pr… 

    …omise implementations

To provide better interop for Promise libraries such as bluebird and Q, this changes
the part of jest-circus that detects a returned Promise from a test or hook to only
check that the value is an object with a then method on it, rather than checking that
the value is instanceof Promise. This is considered the standard way of checking for
a Promises/A+-compliant Promise. As an added bonus, this check works cross-realm.
    @suchipi
    suchipi committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    fd2cc3a View commit details
    Browse the repository at this point in the history

  2. Update utils.js

    @cpojer
    cpojer committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    6374969 View commit details
    Browse the repository at this point in the history