Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testMatch from package.json #4630

Merged
merged 4 commits into from
Dec 6, 2017
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 8, 2017

Summary
I discovered that the testMatch in the root package.json meant that a few test suites did not run.

One was simply old, so I deleted it. Then a bunch of extra files in __tests__ tried to run, so I ignored them.

But it still leaves 3 tests which fails.

image

Test plan
Green CI (eventually)

@SimenB
Copy link
Member Author

SimenB commented Oct 8, 2017

Ok, the snapshot one was just a require -> import fix.

@mjesun Ideas about the jest-worker one?

The iterator-to-null-test I have no idea about (but is eerily familiar from lazy require PR...).

Failing tests:

@SimenB
Copy link
Member Author

SimenB commented Oct 8, 2017

On CI the worker test doesn't fail... @pedrottimark mentioned it only fails if run without -i. Is that supposed to happen?

It points to another test failing which I just didn't wait for, though, the one added in #3672 earlier today. @EnoahNetzach Could you take a look?

Screengrab from Circle for convenience:
image

@SimenB SimenB changed the title Run all tests Remove testMatch from package.json Oct 8, 2017
@EnoahNetzach
Copy link
Contributor

I won't have time before this weekend.
I'll be glad to help then!

@SimenB
Copy link
Member Author

SimenB commented Oct 9, 2017

Rebased on master, but a new failure has snuck in, so we're still at 2 failures! The new test from #3458. /cc @felipeochoa

New screengrab:
image

The sourcemap test passes on node 8, but not 4 or 6

@SimenB
Copy link
Member Author

SimenB commented Oct 22, 2017

Open PR for the sourcemap test: #4744.

@SimenB
Copy link
Member Author

SimenB commented Oct 23, 2017

Rebased, and now we're down to the single iterator-to-null-test.js, which I have no idea how to go about fixing

@SimenB
Copy link
Member Author

SimenB commented Dec 6, 2017

Rebased, and skipping the failing test. Hopefully green ci...

@codecov-io
Copy link

Codecov Report

Merging #4630 into master will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4630      +/-   ##
==========================================
+ Coverage   60.35%   60.74%   +0.39%     
==========================================
  Files         198      197       -1     
  Lines        6639     6596      -43     
  Branches        4        4              
==========================================
  Hits         4007     4007              
+ Misses       2632     2589      -43
Impacted Files Coverage Δ
packages/jest-snapshot/src/plugins.js 80% <0%> (-20%) ⬇️
...ages/jest-worker/src/__performance_tests__/test.js
packages/jest-mock/src/index.js 84.83% <0%> (+0.36%) ⬆️
packages/jest-config/src/normalize.js 92.94% <0%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94101e9...aaeb0f8. Read the comment docs.

@cpojer cpojer merged commit 158ecd3 into jestjs:master Dec 6, 2017
@cpojer
Copy link
Member

cpojer commented Dec 6, 2017

This is so good, thanks for doing this.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants