ignore cache write EPERM errors on Windows #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we're reasonably sure they came from a cross-process race condition
|
@jeanlauliac Thoughts on this? Is it dangerous to ignore the failure? |
SimenB
reviewed
Oct 13, 2017
| * On Windows, renames are not atomic, leading to EPERM exceptions when two | ||
| * processes attempt to rename to the same target file at the same time. | ||
| * If the target file exists we can be reasonably sure another process has | ||
| * legitimately won a cache write race and ignore the error. |
There was a problem hiding this comment.
Can you mention #4444 in the comment so that we'll hopefully come back later and revert this when it's not necessary?
jeanlauliac
approved these changes
Oct 13, 2017
|
Tests are failing for "test-node-8" though, can you investigate and/or rebase the changeset so that we make sure it's all good? Thank you! |
|
I think we can merge this, the node 8 issue was fixed separately. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ignore cache write EPERM errors on Windows if we're reasonably sure they came from a cross-process race condition
Test plan
Race conditions are hard to test for, but I was able to verify this patch resolved the cache write errors I was seeing on Windows as part of a Jest 21 upgrade by logging out errors caught by this check and seeing several hits (alongside passing tests).
This is ideally a temporary fix for #4444. It seems the real fix is upstream at isaacs/node-graceful-fs#119, but in the meantime, this will unblock Windows users trying to upgrade to Jest 21 or later.