Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better console-clearing string on Windows #5251

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jan 8, 2018

This is pretty much the same as facebook/create-react-app#2071.

It seems to work better for more recent Windows versions (according to my testing in facebook/create-react-app#2071 (comment) which I did a few months ago). I haven't verified this again but I can re-test with a Windows laptop in a few days.

@SimenB
Copy link
Member

SimenB commented Jan 9, 2018

Maybe create some "console-clear" npm package?

@gaearon
Copy link
Contributor Author

gaearon commented Jan 9, 2018

Do CI failures make sense to you?

@SimenB
Copy link
Member

SimenB commented Jan 9, 2018

No... We get that error from time to time (currently why master is red on Travis). I think @aaronabramov had some theories at one point, not sure what came of it, though.

@cpojer
Copy link
Member

cpojer commented Jan 9, 2018

Thanks! Do you mind testing this on a real windows computer before we merge this?

@gaearon
Copy link
Contributor Author

gaearon commented Jan 9, 2018

I will. Let me grab a loaner.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 9, 2018

Just tested on Windows again, it definitely works while the previous sequence doesn't.

@codecov-io
Copy link

Codecov Report

Merging #5251 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5251   +/-   ##
=======================================
  Coverage   61.14%   61.14%           
=======================================
  Files         203      203           
  Lines        6843     6843           
  Branches        3        3           
=======================================
  Hits         4184     4184           
  Misses       2658     2658           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/constants.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490f435...1c56fb8. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Jan 9, 2018

New CI passed...

I really don't like that the ansi codes seem to sometimes be missing

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants