Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak from snapshot printing #5279

Merged
merged 4 commits into from
Jan 11, 2018
Merged

Fix memory leak from snapshot printing #5279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffff38d
Fix memory leak from obsolete snapshot printing
rickhanlonii Jan 11, 2018
f8f9af4
Update issue number
rickhanlonii Jan 11, 2018
c9ef1a8
Rm "obsolete" to remove confusion
rickhanlonii Jan 11, 2018
2f27b68
Update index.js
cpojer Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
## master
## jest 22.0.6

### Fixes

* `[jest-jasmine2]` Fix memory leak in snapshot reporting ([#5279](https://github.com/facebook/jest/pull/5279))

## jest 22.0.5

Expand Down
3 changes: 2 additions & 1 deletion packages/jest-jasmine2/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ const addSnapshotData = (results, snapshotState) => {
results.snapshot.unmatched = snapshotState.unmatched;
results.snapshot.updated = snapshotState.updated;
results.snapshot.unchecked = !status.deleted ? uncheckedCount : 0;
results.snapshot.uncheckedKeys = uncheckedKeys;
// Copy the array to prevent memory leaks
results.snapshot.uncheckedKeys = Array.from(uncheckedKeys);

return results;
};
Expand Down