Add a trailing slash to the root pattern #5464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When verifying if a test belongs to a particular project, the root of the project is part of the checks we perform (
roots
is checked against the filename via a regular expression). However, the regular expression did not include a trailing slash (either/
or\
for Windows), which causes to wrongly recognize tests as part of a pattern. For instance:/foo/bar/folder
./foo/bar/folder-with-something
.All tests inside B are executed also through config A, since B starts with A. This leads to tests getting executed twice if not crashing. Adding a trailing slash fixes the problem.