Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description line when assertion fails: part 2 #5512

Merged
merged 4 commits into from
Feb 23, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## master

### Features

* `[jest-matcher-utils]` Add `isNot` option to `matcherHint` function
([#5512](https://github.com/facebook/jest/pull/5512))

## jest 22.2.2

### Fixes
Expand Down Expand Up @@ -37,6 +42,8 @@
* `[diff-sequences]` New package compares items in two sequences to find a
**longest common subsequence**.
([#5407](https://github.com/facebook/jest/pull/5407))
* `[jest-matcher-utils]` Add `comment` option to `matcherHint` function
([#5437](https://github.com/facebook/jest/pull/5437))
* `[jest-config]` Allow lastComit and changedFilesWithAncestor via JSON config
([#5476](https://github.com/facebook/jest/pull/5476))
* `[jest-util]` Add deletion to `process.env` as well
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ exports[`not throwing Error objects 4`] = `
✕ throws when there are not assertions
● .assertions() › throws
expect(received).toBeTruthy()
Expected value to be truthy, instead received
false
Received: false
11 | const throws = () => {
12 | expect.assertions(2);
> 13 | expect(false).toBeTruthy();
Expand All @@ -52,8 +51,7 @@ exports[`not throwing Error objects 4`] = `
Expected two assertions to be called but received one assertion call.
● .assertions() › throws on redeclare of assertion count
expect(received).toBeTruthy()
Expected value to be truthy, instead received
false
Received: false
15 | const redeclare = () => {
16 | expect.assertions(1);
> 17 | expect(false).toBeTruthy();
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/__tests__/jasmine_async.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe('async jasmine', () => {

expect(result.status).toBe(1);
expect(result.json.testResults[0].message).toEqual(
expect.stringContaining('Expected value to be truthy, instead received'),
expect.stringContaining('Received:'),
);
});

Expand Down
Loading