Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version support in README and docs #5622

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Update Node version support in README and docs #5622

merged 1 commit into from
Feb 20, 2018

Conversation

satya164
Copy link
Contributor

@satya164 satya164 commented Feb 20, 2018

Fixes #4947

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #5622 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5622   +/-   ##
======================================
  Coverage    60.9%   60.9%           
======================================
  Files         215     215           
  Lines        7325    7325           
  Branches        3       3           
======================================
  Hits         4461    4461           
  Misses       2863    2863           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4576dd4...186cb05. Read the comment docs.

@thymikee thymikee changed the title Add note about Node version support in README and docs. Fixes #4947 Add note about Node version support in README and docs Feb 20, 2018
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Can you also remove parts about explicitly installing babel-jest? I think we could also remove the references to regenerator-runtime because it's a transitive dependency from babel-runtime that we use

@thymikee thymikee requested a review from SimenB February 20, 2018 16:24
@thymikee thymikee changed the title Add note about Node version support in README and docs Update Node version support in README and docs Feb 20, 2018
@cpojer cpojer merged commit da90886 into jestjs:master Feb 20, 2018
@cpojer
Copy link
Member

cpojer commented Feb 20, 2018

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to Node 4 compat
5 participants