-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for tree processor #6177
Conversation
Don't merge until @niieani gives green light! |
Should we add tests for the order? |
Awesome! |
Needs a snapshot update for a stack change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @mjesun. I've run the webpack suite with the legacy order (as is here) and it passed. Hopefully it will work in the long run.
We should still think about the before/after order in the future.
Codecov Report
@@ Coverage Diff @@
## master #6177 +/- ##
==========================================
- Coverage 64.22% 64.15% -0.07%
==========================================
Files 219 219
Lines 8430 8428 -2
Branches 4 4
==========================================
- Hits 5414 5407 -7
- Misses 3015 3020 +5
Partials 1 1
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR is a revamp of #5885, #6006, and #6100, removing the need of the flag.
cc // @niieani