jest-circus: support globals #6283
Conversation
| @@ -50,10 +50,8 @@ export const makeTest = ( | |||
| parent: DescribeBlock, | |||
| timeout: ?number, | |||
| ): TestEntry => { | |||
| let _mode; | |||
| if (!fn) { | |||
| _mode = 'skip'; // skip test if no fn passed | |||
There was a problem hiding this comment.
We throw if fn is not defined
packages/jest-circus/src/utils.js
Outdated
| @@ -272,3 +270,31 @@ export const invariant = (condition: *, message: string) => { | |||
| throw new Error(message); | |||
| } | |||
| }; | |||
|
|
|||
| // See: https://github.com/facebook/jest/pull/5154 | |||
| function convertDescriptorToString(descriptor) { | |||
There was a problem hiding this comment.
Hate this, but compat 🤷♂️
There was a problem hiding this comment.
is there a place we could put it in jest and share between both jasmine and circus?
There was a problem hiding this comment.
Could add this to jest-util, not sure if we want it though (requires another dep for circus)
There was a problem hiding this comment.
- 1 dep > duplicated code 😛
There was a problem hiding this comment.
i'm fine with both though!
thymikee
force-pushed
the
feat/circus/globals
branch
from
10a10c7
to
0abbc50
Compare
packages/jest-circus/src/utils.js
Outdated
| @@ -272,3 +270,31 @@ export const invariant = (condition: *, message: string) => { | |||
| throw new Error(message); | |||
| } | |||
| }; | |||
|
|
|||
| // See: https://github.com/facebook/jest/pull/5154 | |||
| function convertDescriptorToString(descriptor) { | |||
There was a problem hiding this comment.
is there a place we could put it in jest and share between both jasmine and circus?
| @@ -35,7 +35,7 @@ const handler: EventHandler = (event, state): void => { | |||
| } | |||
| case 'finish_describe_definition': { | |||
| const {currentDescribeBlock} = state; | |||
| invariant(currentDescribeBlock, `currentDescribeBlock mest to be there`); | |||
There was a problem hiding this comment.
not sure what i was even trying to say :)
| @@ -32,7 +32,6 @@ exports[`cannot test with no implementation 1`] = ` | |||
| 4 | test('test, no implementation'); | |||
| 5 | | |||
|
|
|||
| at packages/jest-jasmine2/build/jasmine/Env.js:<<LINE>>:<<COLUMN>> | |||
| at __tests__/only-constructs.test.js:<<LINE>>:<<COLUMN>> | |||
There was a problem hiding this comment.
pretty sure we don't need the LINE COLUMN stuff now that we have proper source maps. not relevant to this PR, though.
There was a problem hiding this comment.
removed anyway, thanks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Part of #4362
Test plan
Globals are green