Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variable Timeout #6427

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Add Variable Timeout #6427

merged 2 commits into from
Aug 13, 2018

Conversation

aofdev
Copy link
Contributor

@aofdev aofdev commented Jun 9, 2018

Add variable timeout example to more understand.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@aofdev aofdev changed the title add variable timeout Add Variable Timeout Jun 9, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #6427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6427   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files         227      227           
  Lines        8697     8697           
  Branches        3        3           
=======================================
  Hits         5521     5521           
  Misses       3175     3175           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb096f8...9d06141. Read the comment docs.

@mattphillips
Copy link
Contributor

LGTM! Would you mind adding an entry to the changelog?

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we lint this stuff?

@SimenB
Copy link
Member

SimenB commented Aug 13, 2018

@thymikee that rule is disabled: https://github.com/facebook/jest/blob/b22a2328d2b7f153dff55043fd4076694f69563a/.eslintrc.js#L32

@SimenB SimenB merged commit c9893d2 into jestjs:master Aug 13, 2018
@thymikee
Copy link
Collaborator

Wonder if we should re-enable if somebody would be interested in fixing errors.

@SimenB
Copy link
Member

SimenB commented Aug 13, 2018

Not sure. If you have multiple examples they would explode.

E.g. https://github.com/facebook/jest/blob/c9893d2f1cdbc98655ca446d2a49f8c77a42b4be/docs/WatchPlugins.md

It defines MyWatchPlugin in the top block. This is the result:
image

ExpectAPI.md:

image

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants