-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing 18 images - 12.51 MiB reduction #6429
Conversation
150.10 KiB => 142.55 KiB (-5%)
128.66 KiB => 109.02 KiB (-15%)
805.99 KiB => 511.21 KiB (-36%)
33.09 KiB => 28.03 KiB (-15%)
51.70 KiB => 31.84 KiB (-38%)
7.25 MiB => 3.82 MiB (-47%)
5.26 MiB => 2.48 MiB (-52%)
4.12 MiB => 1.41 MiB (-65%)
4.52 MiB => 2.23 MiB (-50%)
265.32 KiB => 148.20 KiB (-44%)
179.54 KiB => 99.34 KiB (-44%)
233.85 KiB => 144.74 KiB (-38%)
190.30 KiB => 117.83 KiB (-38%)
824.47 KiB => 655.32 KiB (-20%)
235.91 KiB => 129.32 KiB (-45%)
295.07 KiB => 167.39 KiB (-43%)
344.73 KiB => 246.78 KiB (-28%)
308.19 KiB => 181.83 KiB (-40%)
Codecov Report
@@ Coverage Diff @@
## master #6429 +/- ##
=======================================
Coverage 63.48% 63.48%
=======================================
Files 227 227
Lines 8697 8697
Branches 3 4 +1
=======================================
Hits 5521 5521
Misses 3175 3175
Partials 1 1 Continue to review full report at Codecov.
|
Maybe srcsets + modern compression formats (webp + jpeg) would work even better? |
webp is only supported in Chrome currently, so nope. srcsets are ok, but it's a burden to maintain without a CMS |
I know, that’s why “webp + jpeg”, you can have jpeg as a fallback using You don’t necessarily need a CMS, it can be generated at build time. |
CMS, scripting, you name it. However, if you're interested in bringing such functionality into our website / Docusaurus, that would be awesome 😃 |
Sure, why not. I like Jest :) |
The best would be to land it somehow in https://docusaurus.io/, that way Jest and all other sites using is (React, Prettier etc.) get the improvement for free |
@SimenB @thymikee - Hi 👋 maybe I am not reading this thread correctly - but we added image compression in 1.1 - facebook/docusaurus@ab6bab9 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR optimize the site images, using lossy algorithm. I did one of these in the past (#5349).
You might want to consider using the tool (https://www.shrink.sh) I used to generate this PR. Disclaimer, I am the author, and I wrote it exactly to solve this problem: it is too easy to forget the optimize images. The tool is triggered when new images are pushed on the master branch of a repo. Rebasing my fork with upstream triggered it.
Below is the PR description generated by the tool.
🤖 Reduce image sizes by 49%!
Optimized Images