-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-editor-support]: jest 23.x compatibility #6586
[jest-editor-support]: jest 23.x compatibility #6586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O, yeah, cool, this looks good to me - yep. I've taken a stab at fixing CI in #6587
I didn't notice any obvious problems, but my insight into Jest 23 and jest-editor-support is much lower than in vscode-jest. |
OK, I got merged #6587 - but that doesn't unbreak the build, just moves that fail a bit further up, so I'm going to merge this 👍 |
cc @mjesun |
I'd like to rename the Ref #6380 (comment) |
Oh, and #6603. CI is weird, should be good to land (I restarted the two CIs) |
@SimenB 👌🏻 Feel free to merge all three (I think you have permissions) and I'll then proceed. This looks however like a minor, though. Are you OK with that? |
Yeah, it's a minor. Will merge and keep a screenshot of your comment if @cpojer comes after me with a torch! 😀 |
@mjesun should be ready for release now 🙂 |
thanks for everybody's effort! I checked the release log this morning and it was still at 23.2.0. Is there some other place I should check for the new release? |
@connectdotz was a busy morning, sorry! It's released now :) |
awesome! 👍 |
let settings = null; | ||
|
||
try { | ||
settings = JSON.parse(text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way: When starting up your vscode-jest branch with a CRA app, I always get a "failed to parse config" with text
being just (that's the additional output of npm test -- --showConfig
):
"
> cra-ts-test@0.1.0 test c:\Users\stroy\Projekte\_Playground\cra-ts-test
> react-scripts-ts test --env=jsdom "--showConfig"
"
However since _parseConfig
also gets called with the real settings afterwards, the extensions work without flaw.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR mainly to address jest 23.x compatibility and config parsing issues:
plus some clean up and self-diagnosis:
Test plan
would also like to request @orta, @seanpoulter or @stephtr to review this PR.