-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix beforeEach hook execution order #6673
Conversation
run_describe_start: 2nd level describe | ||
test_start: test | ||
hook_start: beforeEach | ||
before each 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before the fix this would print before each 2
and the next one (line 104) would be before each 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these snapshots, really easy to review
run_describe_start: 2nd level describe | ||
test_start: test | ||
hook_start: beforeEach | ||
before each 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these snapshots, really easy to review
Codecov Report
@@ Coverage Diff @@
## master #6673 +/- ##
==========================================
- Coverage 63.63% 63.61% -0.02%
==========================================
Files 235 235
Lines 8969 8971 +2
Branches 4 3 -1
==========================================
Hits 5707 5707
- Misses 3261 3263 +2
Partials 1 1
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
found a nasty bug where this test:
would print: