fix beforeAll hooks in jest-circus #6681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronabramov
commented
Jul 11, 2018
| @@ -13,16 +13,25 @@ finish_describe_definition: describe | |||
| run_start | |||
| run_describe_start: ROOT_DESCRIBE_BLOCK | |||
| run_describe_start: describe | |||
| hook_start: beforeAll | |||
| > beforeAll | |||
There was a problem hiding this comment.
we even had this snapshot test that captured that hooks will be registered but won't run 😄
Codecov Report
@@ Coverage Diff @@
## master #6681 +/- ##
=========================================
- Coverage 63.61% 63.6% -0.01%
=========================================
Files 235 235
Lines 8971 8972 +1
Branches 3 3
=========================================
Hits 5707 5707
- Misses 3263 3264 +1
Partials 1 1
Continue to review full report at Codecov.
|
thymikee
approved these changes
Jul 11, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hm... i don't even know how be broke it, but apparently we did :)
beforeAllhooks weren't executing at all if there's no other tests in the immediate describe block.