Include createTransformer options in babel-jest's getCacheKey() #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the options passed to `createTransformer()` were not taken into account when generating the cache key, causing incorrect cache hits when the options had changed. Fixes #6698.
Codecov Report
@@ Coverage Diff @@
## master #6699 +/- ##
=======================================
Coverage 63.71% 63.71%
=======================================
Files 235 235
Lines 8998 8998
Branches 3 3
=======================================
Hits 5733 5733
Misses 3264 3264
Partials 1 1Continue to review full report at Codecov.
|
|
Many thanks :-) |
This was referenced Jul 28, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously the options passed to
createTransformer()were not taken into account when generating the cache key, causing incorrect cache hits when the options had changed.Fixes #6698.
Test plan
I've repeated the STR from #6698 in a locally linked copy of Jest, and it no longer reproduces. I did not add a test, since there are no existing tests for
getCacheKey().