-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options #6736
Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options #6736
Conversation
Not sure why the test is reporting a memory leak in |
Codecov Report
@@ Coverage Diff @@
## master #6736 +/- ##
==========================================
- Coverage 63.68% 63.65% -0.03%
==========================================
Files 235 235
Lines 9007 9014 +7
Branches 4 4
==========================================
+ Hits 5736 5738 +2
- Misses 3270 3275 +5
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! Mind updating the changelog as well? 🙂
@SimenB done 👍 |
Anything left that might prevent this PR from landing? 😄 |
* upstream/master: (122 commits) fix: don't report promises as open handles (jestjs#6716) support serializing `DocumentFragment` (jestjs#6705) Allow test titles to include array index (jestjs#6414) fix `toContain` suggest to contain equal message (jestjs#6810) fix: testMatch not working with negations (jestjs#6648) Add test cases for jestjs#6744 (jestjs#6772) print stack trace on calls to process.exit (jestjs#6714) Updates SnapshotTesting.md to provide more info. on snapshot scope (jestjs#6735) Mark snapshots as obsolete when moved to an inline snapshot (jestjs#6773) [Docs] Clarified the use of literal values as property matchers in toMatchSnapshot() (jestjs#6807) Update CHANGELOG.md (jestjs#6799) fix changelog entry that is not in 23.4.2 (jestjs#6796) Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options (jestjs#6736) Update testURL default value from about:blank to localhost (jestjs#6792) fix: `matchInlineSnapshot` when prettier dependencies are mocked (jestjs#6776) Fix retryTimes and add e2e regression test (jestjs#6762) Release v23.4.2 Docs/ExpectAPI: Correct docs for `objectContaining` (jestjs#6754) chore(packages/babel-jest) readme (jestjs#6746) docs: noted --coverage aliased by --collectCoverage (jestjs#6741) ...
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #6462 by adding a check to the
collectCoverage
+findRelatedTests
normalization.If there's
collectCoverageFrom
patterns defined in the config it'll reduce (map + filter) to ensure that the generated patterns do not override existing patterns.It is also no longer overwritten, existing patterns are merged with the dynamic ones.
Test plan
Expand upon the existing
--findRelatedTests
to cover the specific edge cases related tocollectCoverageFrom
patterns.