Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default notifyMode to faluire-change #7024

Merged
merged 3 commits into from
Sep 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- `[pretty-format]` Option to not escape strings in diff messages ([#5661](https://github.com/facebook/jest/pull/5661))
- `[jest-haste-map]` Add `getFileIterator` to `HasteFS` for faster file iteration ([#7010](https://github.com/facebook/jest/pull/7010)).
- `[jest-worker]` [**BREAKING**] Add functionality to call a `setup` method in the worker before the first call and a `teardown` method when ending the farm ([#7014](https://github.com/facebook/jest/pull/7014)).
- `[jest-config]` [**BREAKING**] Set default `notifyMode` to `faluire-change` ([#7024](https://github.com/facebook/jest/pull/7024))

### Fixes

Expand Down
2 changes: 1 addition & 1 deletion TestUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const DEFAULT_GLOBAL_CONFIG: GlobalConfig = {
noStackTrace: false,
nonFlagArgs: [],
notify: false,
notifyMode: 'always',
notifyMode: 'failure-change',
onlyChanged: false,
onlyFailures: false,
outputFile: null,
Expand Down
2 changes: 1 addition & 1 deletion docs/Configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ Activates notifications for test results.

### `notifyMode` [string]

Default: `always`
Default: `failure-change`

Specifies notification mode. Requires `notify: true`.

Expand Down
2 changes: 1 addition & 1 deletion e2e/__tests__/__snapshots__/show_config.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ exports[`--showConfig outputs config info and exits 1`] = `
\\"noStackTrace\\": false,
\\"nonFlagArgs\\": [],
\\"notify\\": false,
\\"notifyMode\\": \\"always\\",
\\"notifyMode\\": \\"failure-change\\",
\\"passWithNoTests\\": false,
\\"projects\\": null,
\\"rootDir\\": \\"<<REPLACED_ROOT_DIR>>\\",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-cli/src/cli/args.js
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ export const options = {
type: 'boolean',
},
notifyMode: {
default: 'always',
default: 'failure-change',
description: 'Specifies when notifications will appear for test results.',
type: 'string',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ module.exports = {
// notify: false,

// An enum that specifies notification mode. Requires { notify: true }
// notifyMode: \\"always\\",
// notifyMode: \\"failure-change\\",

// A preset that is used as a base for Jest's configuration
// preset: null,
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-config/src/Defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default ({
modulePathIgnorePatterns: [],
noStackTrace: false,
notify: false,
notifyMode: 'always',
notifyMode: 'failure-change',
preset: null,
prettierPath: 'prettier',
projects: null,
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-config/src/ValidConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default ({
name: 'string',
noStackTrace: false,
notify: false,
notifyMode: 'always',
notifyMode: 'failure-change',
onlyChanged: false,
preset: 'react-native',
prettierPath: '<rootDir>/node_modules/prettier',
Expand Down
4 changes: 2 additions & 2 deletions packages/jest-validate/src/__tests__/fixtures/jest_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const defaultConfig = {
modulePathIgnorePatterns: [],
noStackTrace: false,
notify: false,
notifyMode: 'always',
notifyMode: 'failure-change',
preset: null,
prettierPath: 'prettier',
resetMocks: false,
Expand Down Expand Up @@ -98,7 +98,7 @@ const validConfig = {
name: 'string',
noStackTrace: false,
notify: false,
notifyMode: 'always',
notifyMode: 'failure-change',
preset: 'react-native',
prettierPath: '<rootDir>/node_modules/prettier',
resetMocks: false,
Expand Down