Move assignment of cwd to default config #7146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Oct 12, 2018
| const setConfig = (contexts, newConfig) => | ||
| contexts.forEach( | ||
| context => | ||
| (context.config = Object.freeze( |
There was a problem hiding this comment.
It's already frozen in jest-config. We only freeze it here because we're creating a new instance, which isn't necessary anymore.
rubennorte
force-pushed
the
move-cwd-to-default-config
branch
from
d0751dd
to
5eccf8c
Compare
SimenB
approved these changes
Oct 12, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cwdis assigned to the project configuration injest-cli, which makes it harder to get a normalized project configuration just usingjest-config. This adds that configuration to the defaults so anyone using it directly can have exactly the same configurationjest-cliwould have with the same parameters.Test plan
I ran all current tests and manually tested that the configuration contained the default
cwd.