chore: add babel plugin to make sure Jest is unaffected by fake Promise implementations #7225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SimenB
commented
Oct 20, 2018
| title: testResult.testPath[testResult.testPath.length - 1], | ||
| }; | ||
| }); | ||
| const assertionResults: Array<AssertionResult> = runResult.testResults.map( |
There was a problem hiding this comment.
ignore whitespace when looking at this diff. I only added the type annotation
SimenB
commented
Oct 20, 2018
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| export type DoneFn = (reason?: string | Error) => void; | |||
| export type BlockFn = () => void; | |||
| export type BlockName = string | Function; | |||
| export type BlockName = string; | |||
There was a problem hiding this comment.
@aaronabramov whenever you find the time, does this make sense? We do not support just a function in describe.
thymikee
reviewed
Oct 20, 2018
This comment has been minimized.
This comment has been minimized.
thymikee
approved these changes
Oct 20, 2018
loganfsmyth
reviewed
Oct 20, 2018
SimenB
force-pushed
the
babel-plugin-jest-promise
branch
from
e7adbf3
to
77b8e82
Compare
|
This has been sitting without objections for a few days, so I'll merge if CI is happy after the rebase |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since users have access to the same globals that Jest does inside the sandbox, they can mess with things Jest needs to function, like doing
global.Promise = undefined. Our approach of just assigning our own localPromiseis brittle in that we have to remember to do it, and it breaks in babel 7. I've verified that at least for Babel 6, this plugin changes the injectedasynToGeneratorhelper from Babel, so the approach should hopefully work for Babel 7 as well.See #7016 (comment)
/cc @loganfsmyth
Test plan
I've looked at the generated code, and it looks correct. I've never written a babel plugin before though, so there might be gotchas?
🤞 for CI