Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only set error codes when they are non zero #7363

Merged
merged 7 commits into from
Nov 21, 2018
Merged

fix: only set error codes when they are non zero #7363

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
165d450
fix: only set error codes when they are non zero
jcreamer898 Nov 13, 2018
6597ceb
fix: check if error code is a non-zero number
jcreamer898 Nov 14, 2018
b6f6469
chore: update changelog
jcreamer898 Nov 14, 2018
c007f96
Update CHANGELOG.md
jcreamer898 Nov 15, 2018
b11f577
fix: remove whitespace
jcreamer898 Nov 16, 2018
2f53da4
move the check inside the process exit handler
jcreamer898 Nov 18, 2018
8ed3dae
add a breaking change notification
jcreamer898 Nov 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### Features

- `[jest-cli]` Only set error process error codes when they are non-zero ([#7363](https://github.com/facebook/jest/pull/7363))
SimenB marked this conversation as resolved.
Show resolved Hide resolved
- `[jest-validate]` Add support for comments in `package.json` using a `"//"` key [#7295](https://github.com/facebook/jest/pull/7295))
- `[jest-config]` Add shorthand for watch plugins and runners ([#7213](https://github.com/facebook/jest/pull/7213))
- `[jest-config]` [**BREAKING**] Deprecate `setupTestFrameworkScriptFile` in favor of new `setupFilesAfterEnv` ([#7119](https://github.com/facebook/jest/pull/7119))
Expand Down
7 changes: 5 additions & 2 deletions packages/jest-cli/src/cli/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,11 @@ const readResultsAndExit = (
globalConfig: GlobalConfig,
) => {
const code = !result || result.success ? 0 : globalConfig.testFailureExitCode;

process.on('exit', () => (process.exitCode = code));

jcreamer898 marked this conversation as resolved.
Show resolved Hide resolved
// Only exit if needed
if (typeof code === 'number' && code !== 0) {
process.on('exit', () => (process.exitCode = code));
SimenB marked this conversation as resolved.
Show resolved Hide resolved
}

if (globalConfig.forceExit) {
if (!globalConfig.detectOpenHandles) {
Expand Down