-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pass watchPathIgnorePatterns
to Haste instance
#7585
Conversation
This seems reasonable to me, and I like that it centralizes ignoring config. Not sure about a test, could mock out |
Codecov Report
@@ Coverage Diff @@
## master #7585 +/- ##
=========================================
- Coverage 68% 68% -0.01%
=========================================
Files 248 248
Lines 9490 9489 -1
Branches 6 6
=========================================
- Hits 6454 6453 -1
Misses 3034 3034
Partials 2 2
Continue to review full report at Codecov.
|
Added a new |
Sorry, wrong button 😅 @thymikee mind rebasing? |
@SimenB updated, can you give it one more check and merge? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
watchPathIgnorePatterns
array was used to verify paths returned by haste instance in watch mode. Instead, it should be passed to the project's Haste instance in form ofignorePattern
.Fixes #7544
Test plan
Yet have to come up with how to test that.