Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instructions for enabling typescript support #7989

Merged
merged 5 commits into from
Feb 26, 2019
Merged

Improve instructions for enabling typescript support #7989

merged 5 commits into from
Feb 26, 2019

Conversation

tjallingt
Copy link
Contributor

Summary

The instructions said that support for typescript was included "out of the box" but failed to mention that it is necessary to install and configure @babel/preset-typescript.

Test plan

N/A

These felt a bit lacking in detail
docs/GettingStarted.md Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Feb 26, 2019

Thanks, this looks great! Could you update the versioned docs as well? https://github.com/facebook/jest/blob/master/website/versioned_docs/version-24.0/GettingStarted.md

@tjallingt
Copy link
Contributor Author

tjallingt commented Feb 26, 2019

@SimenB Thanks for the quick reaction.

Versioned docs should be in line with the main docs now

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@SimenB SimenB merged commit 12542a2 into jestjs:master Feb 26, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants