Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use react-is in pretty-format #8060

Merged
merged 10 commits into from
Mar 7, 2019

Conversation

mishra-prabhakar
Copy link
Contributor

@mishra-prabhakar mishra-prabhakar commented Mar 6, 2019

Summary

Use react-is instead of manual element type checks in pretty-format.

Fixes #7895

Test plan

Existing tests should suffice, as there is no functionality change.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Mar 6, 2019

@Prabhakar-17 seems like 3 tests in packages/pretty-format/src/__tests__/react.test.tsx is failing - could you take a look?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some inline comments.

Please update the changelog (and fix CI 🙂)

@SimenB
Copy link
Member

SimenB commented Mar 6, 2019

You can look at #8058 for how to fix it 🙂

@mishra-prabhakar
Copy link
Contributor Author

@SimenB Finally all checks have passed and fixed the CI as well :)
Please take a look. Thanks

@SimenB SimenB merged commit d4e91c3 into jestjs:master Mar 7, 2019
@SimenB
Copy link
Member

SimenB commented Mar 7, 2019

Thanks @Prabhakar-17!

@mishra-prabhakar
Copy link
Contributor Author

Thanks @SimenB for the patience and the help. This is my first successful PR, looking forward to having many more :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use react-is in pretty-format
3 participants