-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use react-is in pretty-format #8060
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@Prabhakar-17 seems like 3 tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some inline comments.
Please update the changelog (and fix CI 🙂)
You can look at #8058 for how to fix it 🙂 |
@SimenB Finally all checks have passed and fixed the CI as well :) |
Thanks @Prabhakar-17! |
Thanks @SimenB for the patience and the help. This is my first successful PR, looking forward to having many more :) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Use react-is instead of manual element type checks in pretty-format.
Fixes #7895
Test plan
Existing tests should suffice, as there is no functionality change.