Fix ability to transform dependencies required from globalSetup script

[Volune]

Summary

Jest failed to run globalSetup script if it loads esm dependencies from node_modules, even with the transformIgnorePatterns configuration. (For example transformIgnorePatterns: [ 'node_modules/(?!(?:lodash-es)/)' ])
This is caused by pirates ignoring node_modules by default.
This PR disables this behavior, which is redundant with transformIgnorePatterns.

Test plan

Added a test in globalSetup.test.js

[SimenB]

Thanks for the PR!

I thought about doing this, but decided against it (quick mention in #7562). While the default transformIgnorePatterns ignores node_modules, I was afraid of messing up people's test runs if they had customized it. But maybe that's not really an issue?

/cc @thymikee @jeysal wdyt?

[jeysal]

If someone removes node_modules from the transformIgnorePatterns, there's probably a reason for it so I think in general we should respect that. If we add a helpful custom error message in case the transform fails and ship this in a major, I think it's fine.

[Volune]

I made a few changes following comments and after looking at #7562

• I use a fake node_module instead of the lodash-es dependency (so don't need to run yarn and eslint is happy)
• I disable the transformer (matcher will return false) if the transformer is already running. This should prevent issues with transformIgnorePatterns: []. I updated the test accordingly.

[SimenB]

I like how this turned out, thanks!

[SimenB]

Could you rebase on master and fix the linting error?

[codecov-io]

Codecov Report

Merging #8143 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #8143      +/-   ##
==========================================
- Coverage   62.28%   62.24%   -0.05%     
==========================================
  Files         265      265              
  Lines       10440    10448       +8     
  Branches     2538     2540       +2     
==========================================
  Hits         6503     6503              
- Misses       3352     3360       +8     
  Partials      585      585

Impacted Files	Coverage Δ
packages/jest-core/src/runGlobalHook.ts	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5fd7aa...d5eb488. Read the comment docs.

[SimenB]

Thanks!

[pedrottimark]

For your info, I just yarn clean-all and it deleted e2e/global-setup-node-modules/node_modules/example/index.js file, which caused yarn test to fail:

/Users/mark/gitforks/jest/e2e/global-setup-node-modules/setup.js
  7:21  error  Unable to resolve path to module './node_modules/example'  import/no-unresolved

[SimenB]

Bah. @Volune wanna send a PR fixing our script in package.json?

[Volune]

I can have a look tomorrow (I don't have my dev environment now)

Suggestions welcome, I'm thinking:

• put back lodash-es as a dependency (with eslint-ignore for the unresolved import)
• copy the file to node_modules in the test (also with eslint-ignore) (favoring this one for the moment)
• change the clean-e2e script

[pedrottimark]

@Volune @SimenB I will open PR to add another exception to clean-e2e for this test: #8174

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.