-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(watchPlugins): fix argument passed to shouldRunTestSuite #8240
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #8240 +/- ##
=======================================
Coverage 62.33% 62.33%
=======================================
Files 265 265
Lines 10553 10553
Branches 2565 2565
=======================================
Hits 6578 6578
Misses 3387 3387
Partials 588 588 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, turns out it's was merged on a more recent PR (#8784) |
Ah, sorry about that |
Oh no, no worries. It's a lot of prs and issues to handle :)
Eduardo San Martin Morote
… On 12 Nov 2019, at 13:17, Simen Bekkhus ***@***.***> wrote:
Ah, sorry about that
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I found the
testPath
was a property of an object and not the direct argument so I updated the doc to usetestSuite
as that's what it looked to me but there is probably a better wordingTest plan
N/A