Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #7089 and add tests to catch the regression(s) in the future. #8405

Merged
merged 1 commit into from
May 1, 2019

Conversation

scotthovestadt
Copy link
Contributor

Summary

See: #7089 (comment)

Test plan

  • Added tests to catch these regression(s) in the future.

@scotthovestadt scotthovestadt requested a review from SimenB May 1, 2019 19:28
@codecov-io
Copy link

Codecov Report

Merging #8405 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8405      +/-   ##
==========================================
- Coverage   62.37%   62.33%   -0.04%     
==========================================
  Files         266      266              
  Lines       10739    10730       -9     
  Branches     2614     2612       -2     
==========================================
- Hits         6698     6689       -9     
  Misses       3459     3459              
  Partials      582      582
Impacted Files Coverage Δ
packages/jest-snapshot/src/utils.ts 92.42% <ø> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c0e6b...573a80f. Read the comment docs.

Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It confused me a minute because reverted PR had replaced tests instead of adding tests.

@scotthovestadt scotthovestadt merged commit 9081612 into jestjs:master May 1, 2019
@timtrinidad
Copy link
Contributor

Should this also remove #7089 from the changelog?

@SimenB
Copy link
Member

SimenB commented May 2, 2019

yeah probably, but since it'll land with #8408 it should be fine 🙂

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants