chore: upgrade some deps #8692
chore: upgrade some deps #8692
Conversation
|
I'm not sure why a couple of the integration tests fail... |
|
Trying #8693, then I can debug this afterwards. I suspect something with the babel deps (I kept some back due to babel/babel#9621, might be some cross-version errors) |
| @@ -41,7 +41,7 @@ | |||
| "@types/exit": "^0.1.30", | |||
| "@types/graceful-fs": "^4.1.2", | |||
| "@types/micromatch": "^3.1.0", | |||
| "@types/p-each-series": "^1.0.0", | |||
| "@types/p-each-series": "1.0.0", | |||
There was a problem hiding this comment.
newer versions of p-each-series has types, but they are node 8 only. for some reason the types published as 1.0.1 makes type check fail for us...
| ) { | ||
| const ERROR_REGEX = /^Error:?\s\n*/; | ||
|
|
||
| if (stack && message && !stack.includes(message)) { |
There was a problem hiding this comment.
it doesn't hurt to always try to replace
| @@ -344,13 +356,13 @@ export const separateMessageFromStack = (content: string) => { | |||
| // If the error is a plain "Error:" instead of a SyntaxError or TypeError we | |||
| // remove the prefix from the message because it is generally not useful. | |||
| const messageMatch = content.match( | |||
| /^(?:Error: )?([\s\S]*?(?=\n\s*at\s.*\:\d*\:\d*)|\s*.*)([\s\S]*)$/, | |||
| /^(?:Error: )?([\s\S]*?(?=\n\s*at\s.*:\d*:\d*)|\s*.*)([\s\S]*)$/, | |||
There was a problem hiding this comment.
intellij told me I didn't need to escape the :s
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
These should all still support node 6
Test plan
Green CI