-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated matchMedia methods #8835
Conversation
`addListener` and `removeListener` are deprecated in favor of `addEventListener` and `removeEventListener`
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@SimenB done :) By the way, since |
Just missing https://github.com/facebook/jest/blob/master/website/versioned_docs/version-22.x/ManualMocks.md and we're good to go 🙂
Sure, sounds good! |
Actually, this file doesn't have "Mocking methods which are not implemented in JSDOM" section, so there's nothing to fix there.
Done, in both files :) |
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
addListener
andremoveListener
are deprecated in a favor ofaddEventListener
andremoveEventListener
.From MediaQueryList/addListener
They are supported by all major browsers: EventTarget/addEventListener
BTW,
TSLint
is producing the following error when trying to useaddListener
: