Mark maxWorkers as optional

[G-Rath]

Currently maxWorkers in InitialConfig is marked as required, which means normalize is being used in an "unsafe" manner in some places.

Meanwhile getMaxWorkers ensures this value is set in normalise.

I don't think this needs a changelog entry as it's an internal change - externally maxWorkers is technically already optional.

[SimenB]

Everything in InitialOptions is optional. Could you instead remove all the ? and just make it Partial?

[SimenB]

TS did not appreciate rootDir being made optional... Seems like we'll need to adjust normalize as well

[G-Rath]

I suspect this might fail, b/c something will probably be depending on the mutation of the original options object that's passed to normalize.

@SimenB Happy to remove the reliance on mutation if it exists, but if you want to keep it I should just be able to do Object.assign(initialOptions, options) to fix it 🙂

Seems nothing was relying on the mutation - yay!

[G-Rath]

@jeysal The mac build passed all the tests, but failed w/ exit code 1 &:

error‌ Command failed with signal "SIGSEGV".‌

Do you think this could be what's happening in my other PR, & CircleCI just isn't reporting the signal that the command failed w/?

---

Eitherway, I don't have a Mac, so not too sure how to fix this 😕

(just in case I want to find it again)

[jeysal]

Idk, in the other one all jobs are failing so I don't think it's related. I also don't see the SIGSEGV anywhere, maybe I'm missing something

[SimenB]

Seems sensible to me. Mind updating the changelog as well?

[G-Rath]

@SimenB No problem - I'm hoping that the SEGFAULT will magically not happen again 😬

🎉 No segfault! 🎉

I'm also rebasing my snapshot branch, which'll hopefully not have problems with.

If you don't mind me taking advantage of your attention, have you had a chance to look over my comment about doing releases on eslint-plugin-jest?

[codecov-io]

Codecov Report

Merging #8848 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8848      +/-   ##
==========================================
- Coverage   64.72%   64.71%   -0.02%     
==========================================
  Files         277      277              
  Lines       11706    11706              
  Branches     2874     2875       +1     
==========================================
- Hits         7577     7575       -2     
- Misses       3512     3514       +2     
  Partials      617      617

Impacted Files	Coverage Δ
packages/jest-config/src/normalize.ts	81.23% <100%> (ø)	⬆️
packages/jest-environment-node/src/index.ts	48.57% <0%> (-8.58%)	⬇️
packages/jest-test-sequencer/src/index.ts	91.66% <0%> (+2.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8862ec3...6d9a328. Read the comment docs.

[SimenB]

thanks for the patience!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.