Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache transforms within a worker #8890

Merged
merged 3 commits into from
Sep 8, 2019
Merged

fix: cache transforms within a worker #8890

merged 3 commits into from
Sep 8, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 30, 2019 •
edited
Loading

Summary

May or may not fix #7811, but it looks pretty good!

Due to the changes in #7186, we no longer cached transformed files between tests within a single worker. Not sure why, but we get a cache miss in the weakmap. Anyone has any good ideas?

@rafeca I realise you don't work at FB aymore, but FYI just in case you remember some context or have any comments 🙂

Test plan

Added test. Without the changes in ScriptTransformer, this is the result of the new test:

image

(I've since tweaked this test to work on Windows, but it's still essentially accurate)

@SimenB SimenB mentioned this pull request Aug 30, 2019
Closed
SimenB
SimenB commented Aug 30, 2019
View reviewed changes
packages/jest-transform/src/ScriptTransformer.ts
Config.ProjectConfig,
ProjectCache
> = new WeakMap();
const projectCaches = new Map<string, ProjectCache>();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not the correct fix, but with this change the tests pass at least, which is a good start 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is alright.

thymikee
thymikee approved these changes Aug 30, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #8890 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8890      +/-   ##
==========================================
+ Coverage   64.24%   64.24%   +<.01%     
==========================================
  Files         275      275              
  Lines       11656    11657       +1     
  Branches     2844     2844              
==========================================
+ Hits         7488     7489       +1     
  Misses       3544     3544              
  Partials      624      624
Impacted Files Coverage Δ
packages/jest-transform/src/ScriptTransformer.ts 68.91% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5545730...b854854. Read the comment docs.

jeysal
jeysal approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will have the desired effect 🙏

cpojer
cpojer approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit!

@SimenB
Copy link
Member Author

SimenB commented Sep 2, 2019 •
edited
Loading

repo checkout timed out on azure, and everything passed before merging in master, so the failure is w/e.

@scotthovestadt could you test this at FB and merge+release if it looks OK? 🙂

@SimenB SimenB mentioned this pull request Sep 4, 2019
Open
@thymikee thymikee merged commit 04efbeb into jestjs:master Sep 8, 2019
@thymikee
Copy link
Collaborator

thymikee commented Sep 8, 2019

Let's have this merged already, as folks reportedly come back with better results. @scotthovestadt feel free to test the latest master then :)

@SimenB SimenB deleted the transform-fix branch September 8, 2019 13:04
This was referenced Jan 28, 2020
Open
Open
This was referenced Feb 4, 2020
Open
Open
Open
Open
This was referenced Feb 18, 2020
Open
Open
Open
@Leko Leko mentioned this pull request Feb 25, 2020
Open
This was referenced Mar 3, 2020
Open
Open
This was referenced Mar 10, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
This was referenced Mar 24, 2020
Open
Open
This was referenced Apr 16, 2020
Open
Open
Merged
Closed
Merged
This was referenced Apr 30, 2020
Closed
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal approved these changes

@thymikee thymikee thymikee approved these changes

@cpojer cpojer cpojer approved these changes

@scotthovestadt scotthovestadt Awaiting requested review from scotthovestadt

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jest 24 is slower than Jest 23.6.0 on the same test suite
6 participants
@SimenB @codecov-io @thymikee @cpojer @jeysal @facebook-github-bot