Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align snapshots in expect #8976

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

pedrottimark
Copy link
Contributor

Summary

Display colors concisely and clearly to review changes quickly and confidently

Too bad about the blame, but the next pull request to expect will illustrate the benefit

Test plan

Updated 903 snapshots:

file
1 assertionCounts.test.ts.snap
7 extend.test.ts.snap
521 matchers.test.ts.snap
308 spyMatchers.test.ts.snap
66 toThrowMatchers.test.ts.snap

Substring differences for the win to review changes locally before updating snapshots :)

But double tests for spy and toThrow matchers added insult to eye injury :(

@codecov-io
Copy link

Codecov Report

Merging #8976 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #8976   +/-   ##
======================================
  Coverage    63.9%   63.9%           
======================================
  Files         277     277           
  Lines       11652   11652           
  Branches     2860    2860           
======================================
  Hits         7446    7446           
  Misses       3576    3576           
  Partials      630     630

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3adb67b...71db313. Read the comment docs.

@pedrottimark pedrottimark merged commit 630350a into jestjs:master Sep 24, 2019
@pedrottimark pedrottimark deleted the align-expect branch September 24, 2019 22:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants