chore: update test for new node 12 error message #9030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Oct 9, 2019
| @@ -383,7 +383,8 @@ export default class ScriptTransformer { | |||
|
|
|||
| if ( | |||
| e instanceof SyntaxError && | |||
| e.message.includes('Unexpected token') && | |||
| (e.message.includes('Unexpected token') || | |||
| e.message.includes('Cannot use import')) && | |||
There was a problem hiding this comment.
I guess we can have export here as well now
There was a problem hiding this comment.
seems they haven't special cased that yet
Codecov Report
@@ Coverage Diff @@
## master #9030 +/- ##
======================================
Coverage 63.9% 63.9%
======================================
Files 277 277
Lines 11652 11652
Branches 2860 2860
======================================
Hits 7446 7446
Misses 3576 3576
Partials 630 630
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should fix e.g. https://circleci.com/gh/facebook/jest/72260
Test plan
Green CI