Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in blog posts #9069

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Fix typo in blog posts #9069

merged 4 commits into from
Oct 21, 2019

Conversation

Smittey
Copy link
Contributor

@Smittey Smittey commented Oct 21, 2019

Summary

There was a small typo in the blog post - blog/2019/01/25/jest-24-refreshing-polished-typescript-friendly. "experimantal" -> "experimental" .

Additionally fixed a typo in a CHANGELOG entry. "inceremental" -> "incremental"

Test plan

There isn't one

@facebook-github-bot
Copy link
Contributor

Hi Smittey! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #9069 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9069   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files         277      277           
  Lines       11681    11681           
  Branches     2863     2863           
=======================================
  Hits         7485     7485           
  Misses       3572     3572           
  Partials      624      624

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fee0a...8b4e5ac. Read the comment docs.

jeysal
jeysal reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CHANGELOG.md Outdated
@@ -56,6 +56,7 @@
- `[jest-environment-jsdom]` [**BREAKING**] Upgrade JSDOM from v11 to v15 ([#8851](https://github.com/facebook/jest/pull/8851))
- `[jest-util]` [**BREAKING**] Remove deprecated exports ([#8863](https://github.com/facebook/jest/pull/8863))
- `[jest-validate]` [**BREAKING**] Use ESM exports ([#8874](https://github.com/facebook/jest/pull/8874))
- `[docs]` Fix minor typo in CHANGELOG and blog post ([#9069](https://github.com/facebook/jest/pull/9069))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can omit that for a small change like this so the changelog doesn't get too polluted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Thanks, I'll remove it

website/blog/2019-01-25-jest-24-refreshing-polished-typescript-friendly.md Show resolved Hide resolved
thymikee
thymikee requested changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's remove the new entry to the changelog though

CHANGELOG.md Outdated
@@ -56,6 +56,7 @@
- `[jest-environment-jsdom]` [**BREAKING**] Upgrade JSDOM from v11 to v15 ([#8851](https://github.com/facebook/jest/pull/8851))
- `[jest-util]` [**BREAKING**] Remove deprecated exports ([#8863](https://github.com/facebook/jest/pull/8863))
- `[jest-validate]` [**BREAKING**] Use ESM exports ([#8874](https://github.com/facebook/jest/pull/8874))
- `[docs]` Fix minor typo in CHANGELOG and blog post ([#9069](https://github.com/facebook/jest/pull/9069))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to add this to the changelog, please remove

@thymikee thymikee changed the title Fixing typo in blog post and CHANGELOG Fix typo in CHANGELOG Oct 21, 2019
@thymikee thymikee merged commit bd48ccc into jestjs:master Oct 21, 2019
@Smittey Smittey changed the title Fix typo in CHANGELOG Fix typo in blog posts Oct 21, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal left review comments

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Smittey @facebook-github-bot @codecov-io @thymikee @jeysal