-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-types): tighten Config types and set more defaults #9200
Conversation
203b063
to
619e01d
Compare
Codecov Report
@@ Coverage Diff @@
## master #9200 +/- ##
==========================================
- Coverage 64.85% 64.79% -0.06%
==========================================
Files 279 279
Lines 11744 11764 +20
Branches 2888 2897 +9
==========================================
+ Hits 7616 7622 +6
- Misses 3510 3514 +4
- Partials 618 628 +10
Continue to review full report at Codecov.
|
* master: chore: upgrade to fsevents 2 (jestjs#9215) docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149) chore: bump to istanbul alphas (jestjs#9192) Fix typo in JestPlatform.md (jestjs#9212) jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203) fix(jest-types): tighten Config types and set more defaults (jestjs#9200) jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132) jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198) chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197) fix(pretty-format): correctly detect memo (jestjs#9196) chore: regenerate lockfiles in e2e tests (jestjs#9193) chore: bump handlebars
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
#9197 showed me how wrong some of the types output by
normalize
is. While we have plans to overhaul it (and config in general), I've gone through now and ensured that the output from--show-config
is actually validGlobalConfig
andProjectConfig
. I've also tightened some types which were unnecessarily wide (mostly bothnull
andundefined
, and somebooleans
that are always set)Test plan
Green CI.
Not sure how to add an automated test. I think we should hold off for now, and add something together with the config rewrite. Probably
runtypes
,io-ts
or something similar