-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: using html entities for AUTOGENERATED_TABLE_OF_CONTENTS [WIP] #9202
fix: using html entities for AUTOGENERATED_TABLE_OF_CONTENTS [WIP] #9202
Conversation
Hi mayankmandloi! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #9202 +/- ##
=======================================
Coverage 64.85% 64.85%
=======================================
Files 279 279
Lines 11744 11744
Branches 2887 2887
=======================================
Hits 7616 7616
Misses 3510 3510
Partials 618 618 Continue to review full report at Codecov.
|
This is quite a duplicate of #9189. Can you evaluate which solution is better/more complete? Thanks :) |
@thymikee I am not able to make both solution work, can you please suggest better approach, probably the issue is with docusaurus. |
I'd go with #9189 for now, as it seems more complete on a quick glance, and let Docusaurus fix it in the meantime. Are you ok with closing this one then? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
resolving issue number #9169