Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using html entities for AUTOGENERATED_TABLE_OF_CONTENTS [WIP] #9202

Conversation

mayankmandloi
Copy link

@mayankmandloi mayankmandloi commented Nov 18, 2019

resolving issue number #9169

@facebook-github-bot
Copy link
Contributor

Hi mayankmandloi! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #9202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9202   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files         279      279           
  Lines       11744    11744           
  Branches     2887     2887           
=======================================
  Hits         7616     7616           
  Misses       3510     3510           
  Partials      618      618

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0b5e2...debef1f. Read the comment docs.

@mayankmandloi mayankmandloi reopened this Nov 18, 2019
@mayankmandloi mayankmandloi changed the title fix: using html entities for AUTOGENERATED_TABLE_OF_CONTENTS fix: using html entities for AUTOGENERATED_TABLE_OF_CONTENTS [WIP] Nov 18, 2019
@thymikee
Copy link
Collaborator

This is quite a duplicate of #9189. Can you evaluate which solution is better/more complete? Thanks :)

@mayankmandloi
Copy link
Author

@thymikee I am not able to make both solution work, can you please suggest better approach, probably the issue is with docusaurus.
Thanks a lot :)

@thymikee
Copy link
Collaborator

I'd go with #9189 for now, as it seems more complete on a quick glance, and let Docusaurus fix it in the meantime. Are you ok with closing this one then?

@mayankmandloi mayankmandloi deleted the Incorrect-testRegex-link-in-document-#9169 branch November 20, 2019 01:54
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants