Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note for verbose option defaults #9279

Merged
merged 4 commits into from
Feb 13, 2020
Merged

docs: add note for verbose option defaults #9279

merged 4 commits into from
Feb 13, 2020

Conversation

thernstig
Copy link
Contributor

Summary

Indicate what the default is if only one test file is being run.

Fixes #9205

Indicate what the default is if only one test file is being run.
@facebook-github-bot
Copy link
Contributor

Hi thernstig! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Dec 8, 2019

Codecov Report

Merging #9279 into master will increase coverage by 0.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #9279     +/-   ##
=========================================
+ Coverage   64.92%   65.03%   +0.1%     
=========================================
  Files         278      286      +8     
  Lines       11893    12140    +247     
  Branches     2933     3008     +75     
=========================================
+ Hits         7722     7895    +173     
- Misses       3542     3606     +64     
- Partials      629      639     +10
Impacted Files Coverage Δ
e2e/v8-coverage/no-sourcemap/x.css 100% <ø> (ø)
...ckages/jest-config/src/ReporterValidationErrors.ts 11.76% <ø> (ø) ⬆️
packages/babel-plugin-jest-hoist/src/index.ts 0% <ø> (ø) ⬆️
packages/jest-jasmine2/src/jasmineAsyncInstall.ts 0% <ø> (ø) ⬆️
packages/jest-jasmine2/src/reporter.ts 59.52% <ø> (ø) ⬆️
packages/diff-sequences/src/index.ts 100% <ø> (ø) ⬆️
packages/jest-config/src/Descriptions.ts 100% <ø> (ø) ⬆️
packages/jest-haste-map/src/ModuleMap.ts 56.25% <ø> (ø) ⬆️
packages/jest-jasmine2/src/setup_jest_globals.ts 0% <ø> (ø) ⬆️
packages/jest-core/src/ReporterDispatcher.ts 89.47% <ø> (ø) ⬆️
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da01698...eaf1aae. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update the versioned docs as well?

@thernstig
Copy link
Contributor Author

@SimenB All of them? It's hard for me to know exactly how long this has been true. Possibly from the start, but who knows.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB changed the title Configuration: Add note for verbose option docs: add note for verbose option defaults Feb 13, 2020
@SimenB SimenB merged commit ccd0016 into jestjs:master Feb 13, 2020
@thernstig thernstig deleted the verbose_default branch February 13, 2020 21:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: verbose's default is "true" and not "false"
4 participants