-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Transform file paths into hyperlinks" #9294
Conversation
Can't really comment on this, never used a terminal that supports this |
8bf3694
to
0909877
Compare
CI is unhappy. WRT the revert I have no opinion - they aren't rendered as links for me, so I have no frame of reference of its impact |
@thymikee Like Simen and Tim, this does not affect me. That suggests the benefit-to-risk is not favorable, especially because you found a problem in a widely-used terminal. I trust your judgment. |
I would definitely like to see this PR merged; let me know if I can help! I agree with #8980 (comment) that the jest output looks more cluttered with dashed underlines (and harder to read). For those waiting, here’s a workaround to disable hyperlink underlines in iTerm2: Go to Prefs > Advanced > Underline OSC 8 Hyperlinks and set to “No” |
This is failing CI, happy to merge and release once fixed 😀 |
b21fd80
to
58d5126
Compare
This reverts commit 01fd3a4.
58d5126
to
1e73b56
Compare
@thymikee what's the status here? |
It's not bothering me this much recently, and it seems almost no-one else noticed. I'll close it for now, but happy to review any contributions in this area :) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Reverts #8980.
After #8980 (comment):
Some observations after using this in iTerm:
jest packages
)This feature definitely needs some polish and better support from terminal emulators. Happy to accept future improvements, but for now, let's revert.