Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use file urls when calling import() #9558

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 11, 2020

Summary

Fixes #9544.

Test plan

I've tested this on windows. We have an integration test for this, but we only run windows CI with node v12...

EDIT: As can be seen in #9540, this was failing for node 13 on windows, but now passing

@codecov-io
Copy link

Codecov Report

Merging #9558 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9558   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files         286      286           
  Lines       12123    12123           
  Branches     3004     3004           
=======================================
  Hits         7885     7885           
  Misses       3600     3600           
  Partials      638      638
Impacted Files Coverage Δ
packages/jest-config/src/importMjs.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aef448...ad8d874. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running jest with ES Modules on windows fails
3 participants