-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: toEqual
throws error when comparing readonly properties
#9575
fix: toEqual
throws error when comparing readonly properties
#9575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9575 +/- ##
=========================================
Coverage ? 65.03%
=========================================
Files ? 286
Lines ? 12142
Branches ? 3009
=========================================
Hits ? 7897
Misses ? 3606
Partials ? 639
Continue to review full report at Codecov.
|
Thank you! |
We rely on |
There's a bug where `toEqual` throws when comparing readonly properties, which affects our JSX matchers. jestjs/jest#9575 The bug is fixed in master, but not yet released. Until then, downgrading to 24.
Just a heads up we'll need to revert the upgrade and downgrade to 24 in the meantime. |
What happens in this fix if the object has a setter that throws or causes a side-effect (e.g. logs)? |
Filed an issue for setters. #9745 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #9531