Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vscode eslint on save settings #9584

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

thymikee
Copy link
Collaborator

Summary

eslint.autoFixOnSave was deprecated.

Test plan

VSCode on save runs eslint

@thymikee
Copy link
Collaborator Author

cc @cpojer this should fix issues you have with saving the file and applying different formatting

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thymikee thymikee merged commit 1ed46e7 into jestjs:master Feb 17, 2020
@thymikee thymikee deleted the fix/vscode-eslint branch February 17, 2020 14:28
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants