Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage reporter for uncovered files without transformers #9724

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 29, 2020

Summary

The source map for some reason beaks code coverage for uncovered files, as discovered in prettier. This reverts the commit that broke it, and adds a regression test.

Reverts #9460. /cc @mbpreble

Test plan

Regression test added.

*
* Previous behavior of emitting no map when we can't map back to original source is preserved.
*/
sourceMaps: canMapToInput ? 'both' : false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifically this line that breaks. I can keep everything else and just remove this line (or set it to false) and everything works again. But I thought a full revert makes more sense than a partial one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Revert seems appropriate given how confusing this area is.

Hopefully can re-attempt this one soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants