Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop getters and setters when diffing objects for error #9757

Merged
merged 14 commits into from
Apr 3, 2020
Merged

fix: drop getters and setters when diffing objects for error #9757

merged 14 commits into from
Apr 3, 2020

Commits on Apr 2, 2020

  1. fix: do not override properties with setters when diffing objects

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    2a33596 View commit details
    Browse the repository at this point in the history

  2. link to PR

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    4dcb197 View commit details
    Browse the repository at this point in the history

  3. remove setters rather than ignoring properties that have them

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    395abcd View commit details
    Browse the repository at this point in the history

  4. only set writable if not getter and no setter

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    3503d77 View commit details
    Browse the repository at this point in the history

  5. add some frozen and not example with getters and setters

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    b14a485 View commit details
    Browse the repository at this point in the history

  6. use hasOwnProperty

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    cf56846 View commit details
    Browse the repository at this point in the history

  7. just create a new descriptor

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8f5824c View commit details
    Browse the repository at this point in the history

  8. simplify replaceable

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    3aed077 View commit details
    Browse the repository at this point in the history

  9. write tests that actually fail on master

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    9ff198f View commit details
    Browse the repository at this point in the history

  10. remove faulty test and re-add enumerable check

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    5f72f4e View commit details
    Browse the repository at this point in the history

  11. move enumarable check

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    30495ca View commit details
    Browse the repository at this point in the history

  12. add test for getter -> value change

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    fe41787 View commit details
    Browse the repository at this point in the history

  13. test enumerable skip

    @SimenB
    SimenB committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    1aea89b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. update changelog entry

    @SimenB
    SimenB committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    c0edc89 View commit details
    Browse the repository at this point in the history