Add last 3 actual calls for toBeCalledWith message

[petetnt]

This PR continues from #918 and fixes #954 by adding the last 3 (or less) actual values that were called to the error message when using toBeCalledWith

Details:

• If there are less or exactly 3 calls, it just shows the 3 calls comma separated
• If there's exactly 4 calls, it appends and 1 other call to the message
• If there's more than 4 calls, it appends and X other calls to the message (when X is the amount > 3)
• The calls are sliced from the end of the calls array and the messages are reversed so they appear in "correct" order.

Tests included (plus 2 typo fixes in the same test file )

Ping @cpojer

[cpojer]

This is fantastic! I'll land it tomorrow :)

Should we also do this or something similar for lastCalledWith (and potentially factor the code out into a reusable piece)?

[petetnt]

I was thinking about the lastCalledWith case, I think that the current implementation (of showing the last call only) is correct but I think that the message should be something like Wasn't called last with the expected values.\n instead of just Wasn't called with the expected values.\n for extra clarity (ditto for the not called-message few lines below).

Then again showing the last X calls could have some extra merit for debugging purposes for lastCalledWith too.

[cpojer]

@facebook-github-bot import

[ghost]

Thanks for importing. If you are an FB employee go to Phabricator to review.

[cpojer]

@facebook-github-bot shipit

[ghost]

Thanks for importing. If you are an FB employee go to Phabricator to review.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.