Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to preventing over-escaping in FsCodec.SystemTextJson standard profile #44

Closed
bartelink opened this issue Apr 8, 2020 · 2 comments
Closed

Default to preventing over-escaping in FsCodec.SystemTextJson standard profile #44

bartelink opened this issue Apr 8, 2020 · 2 comments

Comments

@bartelink
Copy link
Collaborator

bartelink commented Apr 8, 2020 •
edited
Loading

As part of #38, we need to avoid uglification for usage in events and messages by using the technique in dotnet/runtime#28567 (comment)
cc @ylibrach @NickDarvey
(do they have any other such "opinion" stuff?)
@bartelink bartelink mentioned this issue Apr 8, 2020
Merged
9 tasks
@bartelink bartelink changed the title Prevent "HTML" over-escaping in FsCodec.SystemTextJson standard profile Default to preventing over-escaping in FsCodec.SystemTextJson standard profile Apr 8, 2020
@bartelink
Copy link
Collaborator Author

See proviso in https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-how-to?view=netcore-3.0#serialize-all-characters
Should provide a flag in the Options ctor to enable opting in though

@bartelink bartelink mentioned this issue Apr 14, 2020
Merged
bartelink added a commit that referenced this issue Apr 14, 2020
@bartelink
Default to not over-escaping in SystemTextJson re #44 (#45)
58a30ec
@bartelink
Copy link
Collaborator Author

Implemented in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartelink