fix(NewtonsoftJson)!: Upgrade RecyclableMemoryStream re MissingMethodException #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
changed the title
bartelink
changed the title
bartelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecylableMemoryStreamV3 has a breaking change toGetStream(it returnsRecyclableMemoryStreaminstead ofMemoryStream)This means that the transitive dependency on
>=2.3.2is unsafe (MissingMethodExceptionsif you supply a V3).While I'm tempted to rip the usage out entirely in order to align the NSJ impl with the STJ impl, I've opted to do a minor change for now to simply require the newer version (which makes sense given FsCodec V3 has plenty other changes)
It can also be argued that the dep should now change to
[3.0.0, 4.0.0), but I feel this is overly defensive given that it is a broadly used library that the Bing team/Ben uses heavily and maintains.If I'm proven very wrong, then the likely next fix to something like this will be to rip the usage out given nobody that's worried about allocations is likely to be on NSJ in the pretty near term.