-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port UnionConverter to STJ #43
Closed
Closed
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f78df5d
wip
bartelink 1ac36de
Makes things compile
NickDarvey f225bf5
Ports tests to STJ
NickDarvey 1d7850a
Answered my own question
NickDarvey 1c37108
Gets serializing working at least a lil
NickDarvey 6febb49
Moves converters into FsCodec.SystemTextJson.Converters namespace for…
NickDarvey b512640
Serialization passes when converters are manually specified
NickDarvey c237c58
Fixes attribute usage so you don't have to specify them in options.
NickDarvey 8ae5deb
Handles missing properties
NickDarvey 92e5f36
Enables unmatched case handling tests
NickDarvey 3b138f2
Adds `JsonUnionConverterOptionsAttribute` so users can specify their …
NickDarvey 95ac2da
Removes FsCodec.SystemTextJson.Converters namespace
NickDarvey 104dbaf
Removes missing member handling tests as it's no longer supported
NickDarvey a5cfd76
Adds JsonElement test
NickDarvey a61af4f
Adds test for struct-based DUs
NickDarvey a5ad973
Removes UnionConverter JsonConverterFactory so each DU requires a spe…
NickDarvey 824a903
Explicitly declares union when registering converter
NickDarvey ab45ca3
Reduces greediness
NickDarvey aeb3363
Moves small things on to one line, fixes incorrect comments
NickDarvey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Options.Create