Hyphens in StreamName identifiers
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
reviewed
Nov 9, 2020
bartelink
reviewed
Nov 9, 2020
Can you add a link to This looks great, thanks so much for taking the time to clarify both the code and the doc - will likely merge tomorrow |
|
Isn't it like 2am where you are? Go to sleep! :D |
|
It was, and I did ;) Thanks again for the the clean PR |
|
Interesting ... I wasn't paying attention when I merged - turns out your test reveals a bug in the exception! a0a9776 |
|
Hah - I thought the exception message was a bit odd-looking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it clearer that
Identifiers inStreamNames may contain hyphens.Side note: the FsCodec readme mentions
$ec, but I'm not seeing anything about that on ESDB's website or in their code. Is it perhaps out of date? I admittedly have not searched very hard.