-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Serdes stateful #70
Conversation
21172cd
to
954fea0
Compare
I completely missed this PR. |
Sorry, I didn't spend a long time flagging it (I mentioned it on the DDD-CSQRS-ES #equinox slack); it was to my mind a pretty straightforward logical implication of the I'm sure you're aware, but for avoidance of doubt, there are With regard to having a global default, looking at the completely default
While I'm happy with the policies in it, the introduction of policies that are hard to have a singular view on is what forced the issue, in particular the use of the TypeSafeEnumOrUnionConverterFactory. (and that was even before #71 entered the picture, although I did have such tradeoffs very much in mind when doing this) IME its bad news to have a global strategy that random parts of your app can invoke without telling anyone, even if it feels great to have an obvious global policy that nobody needs to debate or second guess. (This is ironically based on hard won experience in the cart system that ironically The positives of this design are:
In particular this means one can define a set of JSO for a given scope (batch of controllers, part of a domain layer, kafka topic contract) and tie any ser/des activity to that. Thoughts?
|
Enables cleaner integration of #69